docs: fix licensing info for generated files #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change generate_cvss_enums.go to note that the input file is relevant for the license. * change license and copyright of cvss20enums.go and cvss3enums.go to BSD-3-Clause and FIRST. * add reuse.software 3.0 compatible files for the schema cvss files.
|
I might have missed that. Why is it assumed to be BSD-3clause? |
The input files are licensed under And see comment in the improved generate_cvss_enums.go: // We from Intevation consider the source code parts in the following
// template file as too insignificant to be a piece of work that gains
// "copyrights" protection in the European Union. So the license(s)
// of the output files are fully determined by the input file. |
|
@s-l-teichmann ping |
s-l-teichmann
requested changes
Jun 20, 2024
There was a problem hiding this comment.
This is not correctly used.
Running go generate ./... in the root folder results in a diff
diff --git a/csaf/cvss20enums.go b/csaf/cvss20enums.go
index 97d2e10..d7c647d 100644
--- a/csaf/cvss20enums.go
+++ b/csaf/cvss20enums.go
@@ -1,5 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: 2017 FIRST.ORG, INC.
+// determine license(s) from input file and replace this line
//
// THIS FILE IS MACHINE GENERATED. EDIT WITH CARE!
diff --git a/csaf/cvss3enums.go b/csaf/cvss3enums.go
index 32e01e3..1367820 100644
--- a/csaf/cvss3enums.go
+++ b/csaf/cvss3enums.go
@@ -1,5 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: 2017 FIRST.ORG, INC.
+// determine license(s) from input file and replace this line
//
// THIS FILE IS MACHINE GENERATED. EDIT WITH CARE!
There should be no diff!
s-l-teichmann
approved these changes
Jun 21, 2024
JanHoefelmeyer
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #534